Correlate Active Orders with Portfolio entries

Re: Correlate Active Orders with Portfolio entries

pipe42 — Tue, 01 Dec 2009 17:38:12 +1300

Re: Correlate Active Orders with Portfolio entries

sleemanj — Tue, 01 Dec 2009 17:29:37 +1300

Your script has a small bug, if there are no entries in the watchlist it fails. Below is a minimal patch.

Edit: The smilies seem to be being replaced in the code block, but you can see what needs to be done there anyway.


--- memorius-ipredict-portfolio-greasemonkey-b65ad4b/ipredict-portfolio.js	2009-11-11 04:52:48.000000000 +1300
+++ patched-ipredict-portfolio.js	2009-12-01 17:26:02.000000000 +1300
@@ -308,11 +308,11 @@
     var watchListTable     = findTable("watch-list");
 
     var activeOrdersBodyRows = getBodyRows(activeOrdersTable);
     var stockIOwnBodyRows    = getBodyRows(stockIOwnTable);
     var shortedStockBodyRows = getBodyRows(shortedStockTable);
-    var watchListBodyRows    = getBodyRows(watchListTable);
+    var watchListBodyRows    = watchListTable ? getBodyRows(watchListTable) : [ ];
 
     var holdings    = [];
     var activeSellOrders = [];
     var activeBuyOrders = [];
 
@@ -416,11 +416,12 @@
             addHoldingsColumn(tr, 2, stockName, holdings, "Short");
             addHoldingsAverageCostColumn(tr, 3, stockName, holdings);
             addNotesColumn(tr, 11, noteKey);
         }
     }
-
+    if(watchListTable)
+    {
     // Add columns to the Watch List table showing holdings and orders
     addHeaderColumn(watchListTable, 1, "Long",      "align-right");
     addHeaderColumn(watchListTable, 2, "Short",     "align-right");
     addHeaderColumn(watchListTable, 3, "Avg. Cost", "align-center");
     addHeaderColumn(watchListTable, 4, "Buy",       "align-right");
@@ -438,10 +439,11 @@
             addOrdersColumn(tr, 4, stockName, activeBuyOrders, holdings);
             addOrdersColumn(tr, 5, stockName, activeSellOrders, holdings);
             addNotesColumn(tr, 10, noteKey);
         }
     }
+    }
 
     // Ensures that old notes (for cleared positions / deleted orders or watches)
     // don't reappear with misleading values if a new position / order or watch
     // is recreated
     removeUnusedNotes(noteKeysPresentOnScreen);

]]>

Re: Correlate Active Orders with Portfolio entries

Funfinite — Sat, 05 Sep 2009 06:38:29 +1200

my earlier post.

(For anyone unfamiliar with it, Greasemonkey is a Firefox plugin which lets you define bits of javascript to customize pages, based on the URL.)

Instructions and more details are here. Use at your own risk, and it may break when the site changes, but the worst it should be able to do is cause a javascript error. Feel free to modify it.

Admin: hopefully this sort of thing is OK under the terms and conditions? It doesn't make any requests to the server, it just uses the text information already in the HTML page and manipulates the HTML with javascript, so it's not really doing anything the browser isn't already doing. Let me know if it's a problem.]]>

Re: Correlate Active Orders with Portfolio entries

admin — Fri, 04 Sep 2009 18:14:01 +1200

Correlate Active Orders with Portfolio entries

Funfinite — Fri, 04 Sep 2009 15:27:33 +1200

- I can't easily see which stocks in my portfolio have corresponding active orders. The 'Owned' / 'Shorted' lists don't show which stocks have matching orders, and the 'Active orders list' does not show which orders are for stocks I already own and which are 'new'.

- The 'Active Orders' list is split over multiple pages, so I can't even easily compare the two lists on one page.

I would like:

- Please please could you get rid of the multiple page split? Just show them all. If I couldn't cope with seeing that many orders, I wouldn't have placed them all.

- Please add something to make it easier to see which orders correspond to stocks already held in the portfolio.

My preference would be for each line in the 'Owned' / 'Shorted' lists to show a small icon with four variants to distinguish the possibilities: 'has buy order', 'has sell order', 'has both buy and sell orders', and 'has no orders'. If you can fit quantities in there as well, that would be useful, but the icon would be enough.

A similar icon should be shown in each line of 'Active orders' distinguishing 'portfolio has long position', 'portfolio has short position', 'portfolio has no position'.

Assuming the page is being generated as one unit, then this shouldn't even need any extra data to be retrieved - the info is already loaded for the two lists, it just needs correlating.

I think this feature might even improve market liquidity - by making it easier for people to track many orders, it would encourage more people to place limit orders.]]>